Reduce cardinality #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value Saves time and means we don't need to check in each case
This is only needed for now at ingress, so we can reduce our metrics cardinality greatly by removing this from other modules.
pavelnikolov
approved these changes
Oct 22, 2019
jstangroome
reviewed
Oct 22, 2019
jstangroome
reviewed
Oct 22, 2019
jstangroome
reviewed
Oct 22, 2019
jstangroome
reviewed
Oct 22, 2019
jstangroome
approved these changes
Oct 22, 2019
Co-Authored-By: Jason Stangroome <jason@section.io>
Rename content_type to content_type_bucket to better reflect what it is
jstangroome
reviewed
Oct 22, 2019
jstangroome
reviewed
Oct 22, 2019
| switch label { | ||
| case "content_type": | ||
| labelValue = strings.Split(labelValue, ";")[0] | ||
| label = "content_type_bucket" |
There was a problem hiding this comment.
In hingsight, I don't think I like this as much as keeping labelValue aligned with the actual content-type.
jstangroome
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.